Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Setup] Remove AdSupport from the list of libraries linked by default #1305

Closed
wants to merge 1 commit into from
Closed

[Setup] Remove AdSupport from the list of libraries linked by default #1305

wants to merge 1 commit into from

Conversation

ide
Copy link
Contributor

@ide ide commented May 15, 2015

Many apps don't need AdSupport, especially not when people are making a sample app to learn React. Apps that do want it can link it in like any other library.

Fixes #1303, see the discussion there.

@ide
[Setup] Remove AdSupport from the list of libraries linked by default
4f3d101 
Many apps don't need AdSupport, especially not when people are making a sample app to learn React. Apps that do want it can link it in like any other library.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2015
@vjeux
Copy link
Contributor

vjeux commented May 15, 2015

@facebook-github-bot import

@vjeux
Copy link
Contributor

vjeux commented May 15, 2015

This is a good workaround, we need to find an easy way to link those back and to mention in the docs that they are not being linked by default

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/832610953454845/int_phab to review.

@sahrens
Copy link
Contributor

sahrens commented May 15, 2015

Thanks James!

I don't think this qualifies as a "workaround" - I think it's straight up the right thing. It will be a total non-issue once we get nice REM/react-native link/some other native dep magic fully up and running.

@vjeux
Copy link
Contributor

vjeux commented May 15, 2015

This is a workaround until we have a good way to link it back :) Then, it's going to be the right thing to do :p

@sahrens
Copy link
Contributor

sahrens commented May 16, 2015

We should leave this out of the sample app permanently. Long term you should be able to just add the JS require, run react-native install or maybe npm install and it will auto-link the workspace and lib.

On May 15, 2015, at 4:42 PM, Christopher Chedeau notifications@github.com wrote:

This is a workaround until we have a good way to link it back :) Then, it's going to be the right thing to do :p

—
Reply to this email directly or view it on GitHub.

@sahrens
Copy link
Contributor

sahrens commented May 16, 2015

Maybe add it to your package.json

On May 15, 2015, at 4:42 PM, Christopher Chedeau notifications@github.com wrote:

This is a workaround until we have a good way to link it back :) Then, it's going to be the right thing to do :p

—
Reply to this email directly or view it on GitHub.

@ide ide closed this in 5f841a9 May 16, 2015
@ide ide deleted the no-ad-support branch May 19, 2015 02:22
ayushjainrksh pushed a commit to MLH-Fellowship/react-native that referenced this pull request Jul 2, 2020
@radko93 @charpeni
chore: update TS template usage with new CLI (RN 0.60) (facebook#1305)
6b2363a 
* chore: update TS template using new CLI

* Update usage for RN 0.60.x

* Update typescript.md
mganandraj pushed a commit to mganandraj/react-native that referenced this pull request Aug 5, 2022
@chiuam
Fix enableFocusRing also enabled for multiline textFields (facebook#1301
a320148 
) (facebook#1305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vjeux vjeux

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RCTAdSupport uses advertisingidentifier which triggers Apple's automated detection upon submit
5 participants
@ide @vjeux @facebook-github-bot @sahrens @reactjs-bot